Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsp add host view mapping #810

Merged
merged 15 commits into from
Apr 28, 2022
Merged

vsp add host view mapping #810

merged 15 commits into from
Apr 28, 2022

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #810 (d8b9bdd) into master (e806602) will decrease coverage by 0.10%.
The diff coverage is 59.77%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   70.58%   70.47%   -0.11%     
==========================================
  Files         181      181              
  Lines       18880    19055     +175     
  Branches     2777     2812      +35     
==========================================
+ Hits        13326    13429     +103     
- Misses       4707     4756      +49     
- Partials      847      870      +23     
Impacted Files Coverage Δ
delfin/drivers/hitachi/vsp/rest_handler.py 40.40% <21.73%> (-1.74%) ⬇️
delfin/drivers/hitachi/vsp/vsp_stor.py 68.55% <65.16%> (-1.97%) ⬇️
delfin/drivers/hitachi/vsp/consts.py 100.00% <100.00%> (ø)
delfin/drivers/fake_storage/__init__.py 93.63% <0.00%> (-0.77%) ⬇️

Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit f5a82ab into sodafoundation:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants